Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Commit c7d68fa

Browse files
committed
chore(ci): also deploy Firebase functions to docs-angularjs-org
Previously, we only deployed to Firebase hosting for the `docs-angularjs-org` Firebase project. This meant that the deployed functions used an old version of Node.js and started failing once support was dropped for that version. See #17111 for details. This commit fixes this by ensuring that we deploy to all enabled Firebase services (currently functions and hosting). Fixes #17111 Fixes angular/angularjs.org#251
1 parent 667ff87 commit c7d68fa

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.circleci/config.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -398,7 +398,7 @@ jobs:
398398
# Do not use `yarn firebase` as that causes the Firebase CLI to look for `firebase.json`
399399
# in the root directory, even if run from inside `scripts/docs.angularjs.org-firebase/`.
400400
firebase=$(yarn bin)/firebase
401-
$firebase deploy --message "Commit:\ $CI_COMMIT" --non-interactive --only hosting --project "docs-angularjs-org-9p2" --token "$FIREBASE_TOKEN"
401+
$firebase deploy --message "Commit:\ $CI_COMMIT" --non-interactive --project "docs-angularjs-org-9p2" --token "$FIREBASE_TOKEN"
402402
403403
workflows:
404404
version: 2

0 commit comments

Comments
 (0)